[Shr-Devel] fix for phonelog

[Tom]

On Fri, Sep 4, 2009 at 4:36 PM, Vinzenz Hersche <hersche at puzzle.ch> wrote:

> > > hello tom,
> > >
> > > 1. i don't know how i could get the phonenumber when the field could
> > > named "dsjannnfdg" or "mysuperphone" or something like.. fso didn't
> care
> > > about this.
> > > because of this i don't know the proper solution.
> >
> > So we should probably discuss this, i.e "create a standard" instead of
> just
> > hacking stuff in all of our apps. At least that's what I think.
> >
> > > 2. i commented it out because i think, it isn't needn't anymore. may
> i'm
> > > wrong, but i think it was just require for the while? so i think, it is
> > > already catched, i like slim files more than fats.. :)
> > >
> > > Error handling is always needed, even when you don't expect errors on a
> >
> > daily basis :)
> yeah, of course..
> i also commented it out to look where the failure cames ;)
>
> then i didn't look anymore if it's possible if other errors could be
> throwen
> or not.. my failure..
> >
> > but well, i didn't study the code so exactly, may it's also needed.
> >
> > > what's your idea about a proper solution? :)
> >
> > If I knew I would have done it myself :)
> mh, but do you doesn't want to build in at least the second try-catch in?
> then
> it's possible to show at least the names of contacts which have the field
> "Phone". at least for me, personal, it was very nerved, i was calling about
> 4
> peobles because i didn't know every nr out of the head (and if them would
> be
> showed, i thinked about our call, we already have)..
>
> i think, this try-catch is not unproper, it's just usefull.. :)
> >
> > > greets
> >
>

I will try and see if I can come up with a better solution. If not, I'll
consider adding your fix. It's just that pyphonelog is ugly enough, no need
to make it worst :)

-- 
Tom.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.shr-project.org/pipermail/shr-devel/attachments/20090904/3d1d98c4/attachment.htm