[Shr-Devel] [RFC][PATCH] message-list-view: use the list scroller events for retriving messages

Sebastian Krzyszkowiak dos at dosowisko.net
Thu Nov 11 22:15:30 CET 2010


On Thu, Nov 11, 2010 at 21:57, Marco Trevisan (Treviño) <mail at 3v1n0.net> wrote:
> Il giorno mer, 10/11/2010 alle 18.43 +0100, Marco Trevisan (Treviño) ha
> scritto:
>> This patch uses the new "scroll,edge,bottom" and "scroll,edge,top" genlist
>> callbacks for populating the message view.
>> By default it loads max MSG_PAGE_SIZE messages per page, then when the message
>> list is scrolled to bottom it tryies to load more messages in the list; when the
>> bottom top edge is reached by scrolling up, the list tries to fetch the previous
>> messages (if they exist).
>
> No comment about this?
> I think that the message app is actually a major issue for SHR, in fact
> if you have many message stored in your database (I've more than 600),
> when you load for the first time that page, the ram usage of the
> phoneuid increases a lot making every phoneuid-based app hang every time
> is called (dialer and call-answer included).
>
> This is a workaround for reducing the issue...

Yup, that's why for messages I use opimd-utils ;x

Though I'm not sure if you should define MSG_PAGE_SIZE or maybe find
some way to find out how many messages will be visible on one screen -
reason: SHR can also run on devices other than Freerunner, so our apps
must work correctly on many different resolutions. (unfortunately,
there is still a lot of work to achieve that...)

Anyway, you have my ACK for this patch. If you want to get it included
faster, just bug mrmoku on IRC ;)

-- 
Sebastian Krzyszkowiak
dos


More information about the Shr-devel mailing list